-
Notifications
You must be signed in to change notification settings - Fork 887
Bug: github auth users should not be able to change their email #1490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Ahh interesting. GitHub users shouldn't be able to change anything about themselves I suppose. |
Yeah that's my thought, @deansheather and I have discussed also not allowing password auth users from changing email as well, since that's also kind of a security issue - An admin invites |
Seems like we should associate OAuth connections separately to the account. I feel like @spikecurtis might have some good thoughts here. |
What are we using "username" and "email" for on the platform? |
@f0ssel will you ping the frontend crew in the #dev-ux channel when you start this so so we can understand what changes may be needed here? We will need to spin up a ticket for that frontend work. |
@f0ssel I have time to do this, want me to pick this up? |
After talking with @deansheather and @Emyrk we've come up with the following proposal: Since users can have both built-in and github auth for a single user, it's not possible to deterministically tell which users are github users and which ones are built-in. Because of the current ambiguity in the system, we are suggesting that no user should be allowed to change email. I can just remove the |
OS Information
coder --version
: dev.coder.com - Coder v0.0.0-devel+680de70Steps to Reproduce
canichangethis@coder.com
Expected
If we allow email changes it should not lock the user out and break the user account.
Actual
The user is locked out and cannot log back in.
Logs
Screenshot
Notes
It seems like we need a good bit more guardrails and validation around this flow, we should not be able to collide on username or email when dealing with oauth.
The text was updated successfully, but these errors were encountered: