Skip to content

Correct log line when using tagged --key provisioner #15126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
f0ssel opened this issue Oct 17, 2024 · 1 comment · Fixed by #15505 or #15588
Closed

Correct log line when using tagged --key provisioner #15126

f0ssel opened this issue Oct 17, 2024 · 1 comment · Fixed by #15505 or #15588
Assignees
Labels
bug risk Prone to bugs s3 Bugs that confuse, annoy, or are purely cosmetic

Comments

@f0ssel
Copy link
Contributor

f0ssel commented Oct 17, 2024

Right now we log a line with the tags we are using for the provisioner, and when using --key it says it's "untagged" which isn't true.

2024-11-06 21:29:27.404 [info]  starting provisioner daemon  tags={}  name=coder-provisioner-67d54c74dc-qds64

The issue is that the key authentication does not have permission to describe the key and get the tags, and since we don't get any from the cli args, it logs that there's no tags.

Options I see:

  1. Add permissions to provisioner keys to get tag information
  2. Remove log line altogether if it's not critical information

Spun out from #15047

@f0ssel f0ssel self-assigned this Oct 17, 2024
@coder-labeler coder-labeler bot added the s3 Bugs that confuse, annoy, or are purely cosmetic label Oct 17, 2024
@f0ssel f0ssel added the multi-org temporary label for multiple organizations related work label Nov 4, 2024
@johnstcn johnstcn assigned johnstcn and unassigned f0ssel Nov 7, 2024
@johnstcn johnstcn removed the multi-org temporary label for multiple organizations related work label Nov 7, 2024
@johnstcn
Copy link
Member

johnstcn commented Nov 8, 2024

Checked with @f0ssel and the best approach seems to be to add a new endpoint authorized by a valid provisioner key and returns the detailed of the provisioner key used to authenticate. Kind of similar to /api/v2/users/me.
This will also allow the provisioner to validate the key before opening a websocket and connecting to coderd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug risk Prone to bugs s3 Bugs that confuse, annoy, or are purely cosmetic
Projects
None yet
3 participants