-
Notifications
You must be signed in to change notification settings - Fork 875
Build timings: I have to refresh the page to see startup script timing #15273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hmm... it seems the timings are being added as the agent's lifecycle is set to ready. 🤔 I will try to figure out a better way to refresh the timings when the agent is ready. |
To solve this issue, we need to define when the agent timings are ready to be displayed. I’m considering the following logic:
|
Could we perhaps always show the timings, and when there's an update: prompt the user to refresh? Since this is such a long-running process, I think we need to be able to show intermediate phases. If we did the above we could simply poll, and if the state (i.e. timings JSON) has changed since the currently visible state then prompt. WDYT? |
@dannykopping, it makes sense. @chrifro, do you have any ideas on how we could show or have a "pending" state for the chart? Or at least for the "run startup scripts"? |
With "timings" do you mean the data under "provisioning"? What happens when new data is available? Can we load it automatically or do we need to reload the page? See Figma |
@chrifro and @dannykopping, what do you think about this? I believe this provides more context to the user regarding why it is still loading. |
@BrunoQuaresma looks good! The copy's grammar should be corrected to "Waiting for agent to become ready...". |
When refetching the timings to progressively display the agent scripts, it causes a layout shift because the chart recalculates the best intervals to fit the bar sizes and inner elements. This issue looks strange and buggy. To avoid the layout shift, I see two options:
In my opinion, the first option is the most reasonable and safest. I suggest we move forward with it and, depending on user feedback, we can consider implementing the second option later. WDYT? @dannykopping @chrifro Screen.Recording.2024-12-02.at.11.53.04.mov |
Yeah I think the first option makes the most sense. You only really need to know the timing information retrospectively; there isn't much value in seeing it while the build is taking place. |
I'm also for option 1 🤝 ✨ |
Screen.Recording.2024-10-29.at.9.47.39.AM.mov
The text was updated successfully, but these errors were encountered: