-
Notifications
You must be signed in to change notification settings - Fork 875
bug(site): no way to set workspace_tags when importing a starter template #15426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@johnstcn I would like to propose a different design. What do you think about having the provisioner tags as a section in the form? Also, is this only required on creating a starter template or any template at all? |
That's fine too! As long as there's an equivalent place to set provisioner tags as with the CLI
For consistency we could show it on any templates. I don't see any reason that we shouldn't show it on templates imported from elsewhere (e.g. uploaded). |
@f0ssel @bcpeinhardt we need to consider this while working on importing registry templates. |
@BrunoQuaresma your proposal looks good to me and it serves the purpose. |
I'm almost done. I just need to add some tests to finish it, but before doing that, I want to confirm the behavior on the quick demo that I recorded below: Screen.Recording.2025-02-20.at.16.16.41.mov |
@BrunoQuaresma WDYT, the Provisioners tags section will only be visible if external provisioners are configured. For internal ones, we generally do not use tags (technically, we can, I think). The suggestion is to make the UI less confusing for users who do not use external providers with special tags and keep the current behavior. @johnstcn and @spikecurtis may provide more context here. |
@matifali I didn't understand your point or what changes should be made 😕 |
@matifali makes a good point. If there are no external provisioners in a deployment, there is no need to show this extra stage. If it is shown unnecessarily, users may erroneously enter provisioner tags that are not needed and be faced with a stuck workspace build. |
Motivation
Our CLI currently allows you to specify
--provisioner-tag
when pushing a template version.Similarly, our UI currently allows you to specify provisioner tags when pushing a template version.
However, when you import a starter template from the UI, there is no way to specify provisioner tags.
This means that you can end up in a situation where you cannot import a starter template if you need the template import job to land on a certain set of provisioners.
Screen.Recording.2024-11-07.at.14.01.18.mov
Workaround
Use the CLI
Suggested Solution
Add a UI component to the starter template import modal to allow specifying provisioner tags on the template import job.
cc @bpmct
The text was updated successfully, but these errors were encountered: