Skip to content

Monochrome logos are barely visible in the light theme. #15559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matifali opened this issue Nov 18, 2024 — with Slack · 0 comments · Fixed by #15572
Closed

Monochrome logos are barely visible in the light theme. #15559

matifali opened this issue Nov 18, 2024 — with Slack · 0 comments · Fixed by #15572

Comments

@matifali Slack
Copy link
Member

matifali commented Nov 18, 2024 •
edited
Loading

The GitHub logo of external auth is barely visible in the light theme.
We should either allow uploading separate logos for dark and light themes or auto-invert colors based on the active theme.

Image
@coder-labeler coder-labeler bot added the design needed Request for more beauty label Nov 18, 2024
@matifali matifali removed the design needed Request for more beauty label Nov 18, 2024
@matifali matifali changed the title Monochrome logos for external auth are barely visible in the light theme. Monochrome logos are barely visible in the light theme. Nov 18, 2024
@matifali matifali mentioned this issue Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use ExternalImage for external auth providers coder/coder
1 participant
@matifali