-
Notifications
You must be signed in to change notification settings - Fork 887
Users page shows confusing "Member" role #1593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@Emyrk we should probably remove that as a role in entirety and assume it by default, right? |
We totally can do that lol. |
Same with org-member |
one use case could be if an "Auditor" was read-only for audit logs and didn't want the ability to create workspaces... but it seems unnecessary. |
Please add your planning poker estimate with ZenHub @Emyrk |
Please add your planning poker estimate with ZenHub @BrunoQuaresma |
closed via #1917 |
@tjcran this still shows it on dev, and the attached PR is merged... I think something got messed up here. |
Are we sure dev is updated? That was only merged like 5 minutes ago @kylecarbs |
Ahh my apologies, deployment is still running. You are correct! |
@Emyrk one issue that resulted here is that "members" only users now have a blank item in the role selector, which doesn't look great. I'm now wondering if it should still display "member" but not allow Member to be a selectable checkbox... What do you think? |
@tjcran I noticed this too. This is a UX/UI question imo. We should not allow removing the "member" role for example, so the previous implementation was incorrect. I think the UX might want to just place a "member" string if there is nothing present? I am ok with the FE team coming up with some placeholder solution, as that will be valid going forward. So @presleyp @BrunoQuaresma ? |
Isn't everyone always a member? What does it mean to be a user on the website and not a member?

The text was updated successfully, but these errors were encountered: