Skip to content

Metrics Cache test doesn't run on Postgres #16710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DanielleMaywood opened this issue Feb 26, 2025 · 0 comments · Fixed by #16711
Closed

Metrics Cache test doesn't run on Postgres #16710

DanielleMaywood opened this issue Feb 26, 2025 · 0 comments · Fixed by #16711
Assignees

Comments

@DanielleMaywood
Copy link
Contributor

Currently, coderd/metricscache/metricscache_test.go runs tests against the dbmem implementation only. This is an issue as the implementation of GetTemplateAverageBuildTime has diverged between dbmem and Postgres.

The divergence occurred here #14576, when dbmem moved to a continuous percentile instead of a discrete percentile. It is worth noting that the original dbmem implementation also exhibited slightly different behavior than Postgres as it calculated the discrete percentile slightly differently, although this likely wasn't spotted as the test wasn't ran on Postgres.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant