Skip to content

Change Timeline Status from workspace status to job status #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #1939
presleyp opened this issue May 23, 2022 · 6 comments · Fixed by #2087
Closed
Tracked by #1939

Change Timeline Status from workspace status to job status #1677

presleyp opened this issue May 23, 2022 · 6 comments · Fixed by #2087
Assignees
@BrunoQuaresma @f0ssel
Labels
site Area: frontend dashboard
Milestone
Community MVP

Comments

@presleyp
Copy link
Contributor

presleyp commented May 23, 2022 •
edited
Loading

Currently, the Timeline has a Status column that shows the workspace status, such as "Running" or "Stopping"

This is redundant with the status bar for the current build, and confusing for past builds (how is it still "Running"?)

Desired: show the workspace.latest_build.job.status in this column instead of the derived workspaceStatus. The desired value will show, for example, Succeeded instead of Running, which makes more sense.
@presleyp presleyp added this to the Enterprise MVP milestone May 23, 2022
@presleyp presleyp added site Area: frontend dashboard Enterprise MVP 🏁 labels May 23, 2022
@presleyp presleyp mentioned this issue May 24, 2022
Closed
@misskniss misskniss mentioned this issue Jun 1, 2022
Closed
90 tasks
@BrunoQuaresma
Copy link
Collaborator

I remember we had a conversation about this and I remember we decided to make it on Enterprise but looks like the status is kinda confusing and I'm wondering if we should do this for Community MVP by making the status "calculation" in the BE. Thoughts?

@presleyp presleyp mentioned this issue Jun 3, 2022
Closed
@presleyp
Copy link
Contributor Author

presleyp commented Jun 3, 2022

@BrunoQuaresma this ticket only needs a small frontend change: show job.status in the workspace Timeline. I think we should do that now, but wait on adding to what the backend sends the frontend.

@presleyp
Copy link
Contributor Author

presleyp commented Jun 3, 2022

@BrunoQuaresma the other change you're referring to is covered here #1720

@ketang
Copy link
Contributor

ketang commented Jun 5, 2022

Wanted to chime in that I continue to be slightly confused and then slightly more frustrated when a job shows "Running" even though it's not.

@ketang ketang mentioned this issue Jun 5, 2022
Closed
@BrunoQuaresma
Copy link
Collaborator

Ahh I see, should we rename the label to "Last job status" instead? cc.: @tjcran @misskniss

@tjcran
Copy link

tjcran commented Jun 6, 2022

Ahh I see, should we rename the label to "Last job status" instead? cc.: @tjcran @misskniss

@BrunoQuaresma yes!

@BrunoQuaresma BrunoQuaresma mentioned this issue Jun 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrunoQuaresma BrunoQuaresma

@f0ssel f0ssel

Labels
site Area: frontend dashboard
Projects
None yet
Milestone
Community MVP
Development

Successfully merging a pull request may close this issue.

refactor: Update workspace status to be the latest job status coder/coder
6 participants
@ketang @presleyp @misskniss @BrunoQuaresma @tjcran @f0ssel