Skip to content

Add filesystem cache for dynamic parameters loading tf files #17052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Emyrk opened this issue Mar 21, 2025 · 0 comments · Fixed by #17141
Closed

Add filesystem cache for dynamic parameters loading tf files #17052

Emyrk opened this issue Mar 21, 2025 · 0 comments · Fixed by #17141
Assignees
Labels
early-access candidate for an early-access, or experimental, release

Comments

@Emyrk
Copy link
Member

Emyrk commented Mar 21, 2025

Dynamic parameters require loading all the *.tf files into memory. These files can be as large as 10MB. To reduce some memory load, we should reuse the existing memory loaded in fs.FS if 2 Create Workspace forms are opened for the same template version.

The fs.FS should be readonly and safe for concurrent usage. The total memory burden should be limited to the amount of uniquely open Create Workspace forms.

@Kira-Pilot Kira-Pilot changed the title Filesystem cache for dynamic parameters loading tf files Add filesystem cache for dynamic parameters loading tf files Apr 2, 2025
@Kira-Pilot Kira-Pilot added the early-access candidate for an early-access, or experimental, release label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
early-access candidate for an early-access, or experimental, release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants