Skip to content

Test validation with Dynamic Parameters with workspace creation flow #17053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Emyrk opened this issue Mar 21, 2025 · 3 comments · Fixed by #17516
Closed

Test validation with Dynamic Parameters with workspace creation flow #17053

Emyrk opened this issue Mar 21, 2025 · 3 comments · Fixed by #17516
Assignees
@aslilac
Labels
early-access candidate for an early-access, or experimental, release

Comments

@Emyrk
Copy link
Member

Emyrk commented Mar 21, 2025 •
edited by Kira-Pilot
Loading

The submit button on the Create Workspace form should submit the latest dynamic parameters as they have been entered. The backend will have to accept these with less scrutiny on validation as the static frame of reference the current code validates against could be incorrect for the set of inputs (user, values, etc).

This should use the existing endpoint; however we need to make sure validation layer is sound and submit button works.

Example being this section of code:

coder/coderd/wsbuilder/wsbuilder.go

Line 536 in 295bceb

func (b *Builder) getParameters() (names, values []string, err error) {

This has to be done by early-access
@bpmct
Copy link
Member

bpmct commented Mar 24, 2025

@coder

@github-actions GitHub Actions
Copy link

Starting a Coder workspace. You can track the progress here.

@github-actions GitHub Actions
Copy link

✅ Workspace has been successfully started! You can access it here.

@Kira-Pilot Kira-Pilot changed the title A "submit" button from the dynamic parameter form Wire up Submit button on the Create Workspace page to post dynamic parameter values Apr 2, 2025
@Kira-Pilot Kira-Pilot added the early-access candidate for an early-access, or experimental, release label Apr 4, 2025
@Kira-Pilot Kira-Pilot changed the title Wire up Submit button on the Create Workspace page to post dynamic parameter values Test validation with Dynamic Parameters with workspace creation flow Apr 18, 2025
@aslilac aslilac mentioned this issue Apr 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aslilac aslilac

Labels
early-access candidate for an early-access, or experimental, release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: loosen static validation when using dynamic parameters coder/coder
4 participants
@aslilac @Emyrk @Kira-Pilot @bpmct