Skip to content

Show ******** when token is pasted in Coder CLI #17059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bpmct opened this issue Mar 22, 2025 · 0 comments · Fixed by #17469
Closed

Show ******** when token is pasted in Coder CLI #17059

bpmct opened this issue Mar 22, 2025 · 0 comments · Fixed by #17469
Assignees
@ibetitsmike
Labels
cli Area: CLI good first issue Easily solved issues suitable for starters and community contributors

Comments

@bpmct
Copy link
Member

bpmct commented Mar 22, 2025

Problem

We have constantly fluctuated between 2 states when people do coder login:

  1. Show the token in plaintext when the CLI token is pasted (not ideal, security risk)
  2. Show nothing when the CLI token is pasted (not ideal, unclear UX)

Suggestion

When the token is pasted, show ********** to replace what is pasted. Some context and implementation details here
@matifali matifali added cli Area: CLI good first issue Easily solved issues suitable for starters and community contributors labels Mar 24, 2025
kylecarbs pushed a commit that referenced this issue Apr 8, 2025
fix: mask pasted tokens during coder login
4fdf42b 
Improves the token input experience in coder login by displaying asterisks when tokens are pasted, providing better visual feedback and security.

Closes #17059

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@ibetitsmike ibetitsmike mentioned this issue Apr 18, 2025
Merged
dannykopping pushed a commit that referenced this issue Apr 24, 2025
@ibetitsmike @dannykopping
feat: enable masking password inputs instead of blocking echo (#17469)
0826e8a 
Closes #17059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibetitsmike ibetitsmike

Labels
cli Area: CLI good first issue Easily solved issues suitable for starters and community contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: enable masking password inputs instead of blocking echo coder/coder
3 participants
@matifali @bpmct @ibetitsmike