Provisioner `CompleteJob` should do all db operations in a transaction #17694

Emyrk · 2025-05-06T19:19:05Z

coder/coderd/provisionerdserver/provisionerdserver.go

Line 1259 in e6acf82

    
           func (s *server) CompleteJob(ctx context.Context, completed *proto.CompletedJob) (*proto.Empty, error) {

Is a 600 line function that does a lot of db mutations. No transaction is used, so partial db mutations can be applied.

This function should be refactored into smaller functions, and do all it's work in a tx.

This commit refactors the CompleteJob function in provisionerdserver.go to use database transactions more consistently for better atomicity guarantees. The large function was broken down into three specialized handlers: - completeTemplateImportJob - completeWorkspaceBuildJob - completeTemplateDryRunJob Each handler now uses the Database.InTx wrapper to ensure all database operations for a job completion are performed within a single transaction, preventing partial updates in case of failures. Added comprehensive tests for transaction behavior for each job type. Fixes #17694 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>

This PR refactors the CompleteJob function to use database transactions more consistently for better atomicity guarantees. The large function was broken down into three specialized handlers: - completeTemplateImportJob - completeWorkspaceBuildJob - completeTemplateDryRunJob Each handler now uses the Database.InTx wrapper to ensure all database operations for a job completion are performed within a single transaction, preventing partial updates in case of failures. Added comprehensive tests for transaction behavior for each job type. Fixes #17694 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Claude <noreply@anthropic.com>

ibetitsmike mentioned this issue May 21, 2025

feat: improve transaction safety in CompleteJob function #17970

Merged

ibetitsmike self-assigned this May 21, 2025

ibetitsmike closed this as completed in #17970 May 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Provisioner `CompleteJob` should do all db operations in a transaction #17694

Provisioner `CompleteJob` should do all db operations in a transaction #17694

Emyrk commented May 6, 2025

Provisioner CompleteJob should do all db operations in a transaction #17694

Provisioner CompleteJob should do all db operations in a transaction #17694

Comments

Emyrk commented May 6, 2025

Provisioner `CompleteJob` should do all db operations in a transaction #17694

Provisioner `CompleteJob` should do all db operations in a transaction #17694