chore: add backed reader, writer and pipe implementation #19147
+2,959
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9dd9c4a to
3223bf9
Compare
d2ee08d to
27da7ef
Compare
e5be506 to
77e912f
Compare
16abe05 to
dde9516
Compare
spikecurtis
reviewed
Aug 13, 2025
spikecurtis
reviewed
Aug 13, 2025
| require.NoError(t, err) | ||
| } | ||
|
|
||
| func TestBackedWriter_ConcurrentWrites(t *testing.T) { |
There was a problem hiding this comment.
The backed writer doesn't currently support concurrent writes (since it releases the mutex while writing).
But, it doesn't need to support writes concurrent with other writes --- we're only ever going to call write serially to send data we get from the reliable stream.
What we do need to care about is writes that are concurrent with Close and Reconnect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18101
This PR introduces a new
backedpipepackage that provides reliable bidirectional byte streams over unreliable network connections. The implementation includes:BackedPipe: Orchestrates a reader and writer to provide transparent reconnection and data replayBackedReader: Handles reading with automatic reconnection, blocking reads when disconnectedBackedWriter: Maintains a ring buffer of recent writes for replay during reconnectionRingBuffer: Efficient circular buffer implementation for storing dataThe package enables resilient connections by tracking sequence numbers and replaying missed data after reconnection. It handles connection failures gracefully, automatically reconnecting and resuming data transfer from the appropriate point.