-
Notifications
You must be signed in to change notification settings - Fork 1k
Closed as not planned
Closed as not planned
Copy link
Labels
apiArea: HTTP APIArea: HTTP APIcliArea: CLIArea: CLIsiteArea: frontend dashboardArea: frontend dashboardstaleThis issue is like stale bread.This issue is like stale bread.
Description
When using SSH (ssh coder.workspace
), the connection remains active after being disconnected from agent.
Steps to reproduce:
coder create workspace
ssh coder.workspace
coder delete workspace
(orstop
,start
)
After step 3, the SSH command remains running until user input. After the switch to Tailscale networking, this applies for both ssh
using ProxyCommand
and coder ssh
. (Also applies to other commands using SSH, like sftp
.)
Typically when an SSH server goes away, the client is notified and we see something like:
Connection to [host] closed by remote host.
Connection to [host] closed.
Ideally we would also detect this client-side by checking workspace status from the coder API, if we're trying to connect to an outdated agent (i.e. workspace state changed after connection), we should either:
- Disconnect and exit
- Reconnect with a "Reconnected, but previous state was lost" (this is not a good message, just to illustrate)
Metadata
Metadata
Assignees
Labels
apiArea: HTTP APIArea: HTTP APIcliArea: CLIArea: CLIsiteArea: frontend dashboardArea: frontend dashboardstaleThis issue is like stale bread.This issue is like stale bread.