Skip to content

Pop out all apps (e.g code-server) like we do terminal #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #1939
ammario opened this issue Jun 7, 2022 · 5 comments · Fixed by #2346
Closed
Tracked by #1939

Pop out all apps (e.g code-server) like we do terminal #2149

ammario opened this issue Jun 7, 2022 · 5 comments · Fixed by #2346
Assignees
Labels
site Area: frontend dashboard
Milestone

Comments

@ammario
Copy link
Member

ammario commented Jun 7, 2022

For one, it's consistent. For two, @mtm20176 thinks it will demo better. We can easily reverse this change too.

@sharkymark
Copy link
Contributor

We can later make a config setting in your profile.

Devs will want their IDE in another window from their dashboard (and corporate apps like email) so they can see all of them at the same time.

@ammario @kylecarbs

@ketang
Copy link
Contributor

ketang commented Jun 8, 2022

Pop out as opposed to a new tab? Seems pretty sensible.

@greyscaled
Copy link
Contributor

greyscaled commented Jun 8, 2022

I'd prefer the manifest-per-application (PWA-pa) approach.

We've done this in v1 with code that assembles the manifest on the fly.

Roughly:

  // Append manifest to head.
  useEffect(() => {
    // construct manifestElement from manifest
    // ...
    const manifestElement = document.createElement("link")
    document.head.appendChild(manifestElement)
  }, [manifest])

An alternative is to make the entire coder dashboard a PWA, but we've gone that route before and it's not as great of an experience as solely having the applications as native-like installs.

@ammario
Copy link
Member Author

ammario commented Jun 8, 2022

@vapurrmaid that seems to be an even better enhancement.

Since the original proposal is a one line change, I think the PWA behavior should be in a separate issue. There's also the matter of how apps behave when the user refuses PWAs.

@ammario
Copy link
Member Author

ammario commented Jun 8, 2022

A large investment bank customer says pop-out is their users' preferred choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site Area: frontend dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants