Skip to content

Be less cowardly about auto-starting failed workspaces #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #5150
johnstcn opened this issue Jun 13, 2022 · 5 comments
Closed
Tracked by #5150

Be less cowardly about auto-starting failed workspaces #2279

johnstcn opened this issue Jun 13, 2022 · 5 comments
Labels
api Area: HTTP API

Comments

@johnstcn
Copy link
Member

johnstcn commented Jun 13, 2022 •
edited
Loading

What

Currently Coder will only attempt to autostart workspaces where:

  • An autostart schedule is set
  • The workspace is not currently transitioning (previous provisioner job completed)
  • The workspace is currently not running (i.e. the latest transition is not start)
  • The latest provisioner job did not encounter an error

This means that:

  • If the autostart build fails, it won't try again until the next scheduled interval
  • If the previous stop failed for any reason, it won't try again until the next scheduled interval
  • If the user manually started the workspace and it failed, it won't try again until the next scheduled interval

It makes sense to be a bit more assertive. Exactly how assertive is TBD, but the following is proposed:

A workspace should be selected as a candidate for autostart if:

  • An autostart schedule is set
  • The workspace is not currently transitioning (previous provisioner job completed)
  • The workspace is currently not running (i.e. the latest transition is not start)
  • No more than 3 previous "start" transitions failed

Why

Because in the real world, things just fail sometimes and you just have to try again.
@johnstcn johnstcn added api Area: HTTP API needs grooming labels Jun 13, 2022
@ketang
Copy link
Contributor

ketang commented Jun 13, 2022

Sold

@kylecarbs kylecarbs removed the go label Jul 21, 2022
@kylecarbs kylecarbs changed the title autobuild: be less cowardly about auto-starting failed workspaces Be less cowardly about auto-starting failed workspaces Sep 23, 2022
@github-actions
Copy link

This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Nov 23, 2022
@johnstcn
Copy link
Member Author

bump

@johnstcn johnstcn removed the stale This issue is like stale bread. label Nov 23, 2022
@presleyp presleyp mentioned this issue Nov 29, 2022
Closed
12 tasks
@github-actions
Copy link

This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Jan 23, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2023
@johnstcn johnstcn reopened this Mar 13, 2023
@johnstcn johnstcn removed the stale This issue is like stale bread. label Mar 13, 2023
@kylecarbs
Copy link
Member

No customers are asking for this right now, so I'm going to close.

@johnstcn reopen if it's important we tackle this in the next 30 days!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Area: HTTP API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ketang @johnstcn @kylecarbs