Skip to content

dev-only: misleading error message "code-server is offline" when clicking on an app #2676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johnstcn opened this issue Jun 27, 2022 · 1 comment
Labels
api Area: HTTP API

Comments

@johnstcn
Copy link
Member

johnstcn commented Jun 27, 2022

Problem

If you try to access a workspace application (for example, code-server) from the webpack server running locally, you will get a message:

code-server is offline!

{{ .APIResponse.Message }}

Problem here is that we populate that with a Go handler, so when running the webpack-only frontend we only display the Go template.

Solution

We should probably display a different error message here so folks know what's going on. This isn't a huge issue, but is bound to trip up folks who are trying to kick the tyres with local development and/or working on some features relating to workspace applications.

@johnstcn johnstcn added api Area: HTTP API go labels Jun 27, 2022
@kylecarbs kylecarbs changed the title bug: (developers only): misleading error message "code-server is offline" dev-only: misleading error message "code-server is offline" when clicking on a n app Aug 24, 2022
@kylecarbs kylecarbs changed the title dev-only: misleading error message "code-server is offline" when clicking on a n app dev-only: misleading error message "code-server is offline" when clicking on an app Aug 24, 2022
@bpmct
Copy link
Member

bpmct commented Sep 21, 2022

Gonna close for now unless you wanna take a look Cian, I actually ran into this today but would rather keep our tracker small for now

@bpmct bpmct closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Area: HTTP API
Projects
None yet
Development

No branches or pull requests

3 participants