-
Notifications
You must be signed in to change notification settings - Fork 881
Make a more helpful UI error message when failing to update schedule #2752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Is the issue that there's not a visible helpful error message even though the back end provides one? |
Pretty much. Given that we seem to be able to know the max TTL ahead of time I shouldn't be able to input a value greater than the maximum. |
This ticket can serve for the FE validation while #3097 handles surfacing BE errors. The FE has the max TTL hard-coded in WorkspaceScheduleForm.tsx, but it should be pulled from the template. |
Moving this to the backlog;. This behavior may change based on #2995 coming up. |
#3497 did most of the work for fixing this and then was closed; when we're ready for more work on this it may be helpful! |
This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity. |
Problem
Updated problem statement
The backend error has been fixed, but the frontend validation of TTL has a bug. It's hard-coded to have a certain max, but in reality the max comes from the template. The frontend should validate based on the template max so the user gets feedback before submitting the form.
Initial problem statement
In this case, the user attempted to add a value that was greater than the maximum TTL. They were prevented from doing so, but the error message was not helpful and did not indicate why it did not work.
payload:
Definition of Done
Given a template has a max TTL of n hours,
When a user enters a TTL higher than n,
Then the user sees red text saying that the "time until shutdown" (not TTL) is higher than their template max, and giving their template max, and the form cannot be submitted.
When the user changes the number to be <= n,
Then the error message disappears and the form can be submitted.
The text was updated successfully, but these errors were encountered: