Skip to content

Refactor provisionerd_tests.go to split provisionerd and runner tests #2780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spikecurtis opened this issue Jul 1, 2022 · 1 comment
Closed

Refactor provisionerd_tests.go to split provisionerd and runner tests #2780

spikecurtis opened this issue Jul 1, 2022 · 1 comment
Labels
api Area: HTTP API stale This issue is like stale bread.

Comments

@spikecurtis
Copy link
Contributor

#2732 splits provisionerd package into provisionerd and provisionerd/runner packages, but leaves all the tests in provisionerd_tests.go

We should refactor the tests so that test cases for the runner are in a runner_test.go in the runner directory, and provisionerd_tests.go just tests the functionality in provisionerd itself.
@spikecurtis spikecurtis added api Area: HTTP API chore labels Jul 1, 2022
@spikecurtis spikecurtis mentioned this issue Jul 1, 2022
Merged
@Kira-Pilot Kira-Pilot self-assigned this Jul 1, 2022
@Kira-Pilot Kira-Pilot removed their assignment Jul 11, 2022
@jsjoeio jsjoeio mentioned this issue Aug 24, 2022
Closed
@github-actions
Copy link

This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Area: HTTP API stale This issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spikecurtis @Kira-Pilot