-
Notifications
You must be signed in to change notification settings - Fork 881
I'm unable to only set an auto-off while leaving on to manual #2792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@spikecurtis is this a duplicate of #2030 ? |
No, it is not.
|
@spikecurtis this is intended behavior (I think). If you specify a start time (in the above screenshot, the start time is 9:30am), you must select at least one day of the week. This is dictated by the BE: And we've designed intentionally around this constraint on the FE and added tests for it. If you clear the start time field, you can successfully submit the form without any days selected. I think what we should do here is amend the validation message so it says something like "Must set at least one day of the week if start time is set" and I can submit a PR for that. |
#3043 is definitely an improvement! But, it seems to me that the same lack of clarity/precision around the error message for days applies equally to the start time. It currently says, unqualified, "Start time is required" when really, "Start time is required if any days are selected" |
Good catch! How about we change that string to |
Fine to tag me, but that language sounds ok. Note I opened a new issue: #3051 with some more minor annoyances and suggestions. I'm not claiming this is high priority! |
I'd like to change the auto-off time for my workspace to 8 hours instead of the default of 12, but I can't seem to be able to without also enabling auto-on.
The text was updated successfully, but these errors were encountered: