Skip to content

I'm unable to only set an auto-off while leaving on to manual #2792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spikecurtis opened this issue Jul 1, 2022 · 6 comments · Fixed by #3043 or #3052
Closed

I'm unable to only set an auto-off while leaving on to manual #2792

spikecurtis opened this issue Jul 1, 2022 · 6 comments · Fixed by #3043 or #3052
Assignees
Labels
site Area: frontend dashboard

Comments

@spikecurtis
Copy link
Contributor

Workspace schedule manual

I'd like to change the auto-off time for my workspace to 8 hours instead of the default of 12, but I can't seem to be able to without also enabling auto-on.

@spikecurtis spikecurtis added bug site Area: frontend dashboard labels Jul 1, 2022
@johnstcn
Copy link
Member

johnstcn commented Jul 1, 2022

@spikecurtis is this a duplicate of #2030 ?

@spikecurtis
Copy link
Contributor Author

spikecurtis commented Jul 2, 2022 via email

@Kira-Pilot Kira-Pilot self-assigned this Jul 18, 2022
@Kira-Pilot
Copy link
Member

Kira-Pilot commented Jul 19, 2022

@spikecurtis this is intended behavior (I think). If you specify a start time (in the above screenshot, the start time is 9:30am), you must select at least one day of the week. This is dictated by the BE:
Screen Shot 2022-07-19 at 11 29 31 AM

And we've designed intentionally around this constraint on the FE and added tests for it. If you clear the start time field, you can successfully submit the form without any days selected.

I think what we should do here is amend the validation message so it says something like "Must set at least one day of the week if start time is set" and I can submit a PR for that.

@spikecurtis
Copy link
Contributor Author

#3043 is definitely an improvement!

But, it seems to me that the same lack of clarity/precision around the error message for days applies equally to the start time. It currently says, unqualified, "Start time is required" when really, "Start time is required if any days are selected"

@Kira-Pilot
Copy link
Member

Good catch! How about we change that string to Start time is required when days of the week are selected? I'm going to tag you in the PR I'm making and you can tweak the language if you like.

@spikecurtis
Copy link
Contributor Author

Fine to tag me, but that language sounds ok. Note I opened a new issue: #3051 with some more minor annoyances and suggestions. I'm not claiming this is high priority!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site Area: frontend dashboard
Projects
None yet
3 participants