Skip to content

Strip leading and trailing whitespace from template CLI parameters #2829

@ketang

Description

@ketang

This did not work (note the leading space before tcp):

$ coder  templates create
> Create and upload "~/project/kode-templates/docker-amd64b"? (yes/no) yes
...
var.docker_host
  Specify location of Docker socket (check `docker context ls` if you're not sure)

> Enter a value:  tcp://localhost:2375
...              ^ extraneous space
  Error: Error initializing Docker client: parse " tcp://localhost:2375": first path segment in URL cannot contain colon

This did:

$ coder templates create
> Create and upload "~/project/kode-templates/docker-amd64b"? (yes/no) yes
...
var.docker_host
  Specify location of Docker socket (check `docker context ls` if you're not sure)

> Enter a value: tcp://localhost:2375
...
[success]

We should strip leading and trailing whitespace from all parameters, especially since any errors caused by this could be pretty cryptic.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions