Skip to content

Workspace SSH access button tooltip provides invalid command #2969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #3042
kconley-sq opened this issue Jul 13, 2022 · 1 comment · Fixed by #3036
Closed
Tracked by #3042

Workspace SSH access button tooltip provides invalid command #2969

kconley-sq opened this issue Jul 13, 2022 · 1 comment · Fixed by #3036
Assignees
@dwahler

Comments

@kconley-sq
Copy link
Contributor

Clicking the new "SSH" access button on a workspace in the Coder website shows a tooltip that reads:

Run the following commands to connect with SSH:

Configure ssh - only needs to be run once, or after managing workspaces

coder config-ssh

Connect to the agent

ssh coder.<WORKSPACE_NAME>.dev

Expected Behavior

Running coder config-ssh and then ssh coder.<WORKSPACE_NAME>.dev in a terminal connects you over SSH to the workspace.

Current Behavior

Running coder config-ssh and then ssh coder.<WORKSPACE_NAME>.dev in a terminal shows the following error:

ssh: Could not resolve hostname coder.<WORKSPACE_NAME>.dev: nodename nor servname provided, or not known

However ssh coder.<WORKSPACE_NAME> works (without .dev). I understand dev is the name we gave to the coder_agent resource in our workspace template file.
@dwahler
Copy link
Contributor

dwahler commented Jul 18, 2022

Yeah, this is IMO a bug in config-ssh.

The behavior of coder ssh is that if the workspace has multiple agents, you have to specify the agent name explicitly, but if there's only one agent, either coder ssh <WORKSPACE_NAME> or coder ssh <WORKSPACE_NAME>.<AGENT_NAME> works.

On the other hand, if there's only a single agent then config-ssh only sets up the SSH config to recognize coder.<WORKSPACE_NAME>, not coder.<WORKSPACE_NAME>.<AGENT_NAME>. We should change this to be consistent with coder ssh.

@kylecarbs kylecarbs changed the title Bug in v0.7.12 6f34cbf: Workspace SSH access button tooltip provides invalid SSH command Workspace SSH access button tooltip provides invalid command Jul 18, 2022
@dwahler dwahler self-assigned this Jul 18, 2022
@dwahler dwahler mentioned this issue Jul 18, 2022
Merged
@kylecarbs kylecarbs mentioned this issue Jul 19, 2022
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dwahler dwahler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config-ssh: always support agent name in host alias coder/coder
3 participants
@dwahler @BrunoQuaresma @kconley-sq