Skip to content

Investigate UsersPage test failure #3210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kira-Pilot opened this issue Jul 26, 2022 · 0 comments · Fixed by #3676
Closed

Investigate UsersPage test failure #3210

Kira-Pilot opened this issue Jul 26, 2022 · 0 comments · Fixed by #3676
Labels
site Area: frontend dashboard

Comments

@Kira-Pilot
Copy link
Member

Kira-Pilot commented Jul 26, 2022

As a FE developer at Coder, I would like to have full test coverage and I would also like to be able to run my test suite without seeing flaking tests.

In #3207 we removed a flaking user test that was frequently failing on main (both locally and in CI). This test was holding up PRs and causing angst when testing locally.

When we have time, we should investigate this test failure more thoroughly and add it back in a more stable way.

Details

181030264-00e81148-1663-4587-b98c-a3f9e4b6c024

../site/src/pages/UsersPage/UsersPage.test.tsx

  ● Users Page › suspend user › when it is success › shows a success message and refresh the page

    expect(jest.fn()).toBeCalledTimes(expected)

    Expected number of calls: 1
    Received number of calls: 2

      195 |
      196 |         // Check if the users list was reload
    > 197 |         await waitFor(() => expect(API.getUsers).toBeCalledTimes(1))
          |                                                  ^
      198 |       })
      199 |     })
      200 |

AC

  • test is added back in
  • test runs consistently locally and in CI

Definition of done

  • AC is completed
@Kira-Pilot Kira-Pilot added site Area: frontend dashboard chore labels Jul 26, 2022
@kylecarbs kylecarbs changed the title Investigate user test failure Investigate UsersPage test failure Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site Area: frontend dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant