Skip to content

User can interpret the question mark icon in the resources list as some kind of problem #3301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BrunoQuaresma opened this issue Jul 29, 2022 · 4 comments · Fixed by #3754
Closed

User can interpret the question mark icon in the resources list as some kind of problem #3301

BrunoQuaresma opened this issue Jul 29, 2022 · 4 comments · Fixed by #3754
Assignees
@jsjoeio
Labels
site Area: frontend dashboard
Milestone
EE

Comments

@BrunoQuaresma
Copy link
Collaborator

BrunoQuaresma commented Jul 29, 2022 •
edited
Loading

image

A suggestion from the community was to replace it with a more generic one like a cube(I'm not sure if there is one like this on MUI).
@BrunoQuaresma BrunoQuaresma added the site Area: frontend dashboard label Jul 29, 2022
@kylecarbs kylecarbs added this to the EE milestone Aug 24, 2022
@jsjoeio jsjoeio self-assigned this Aug 29, 2022
@jsjoeio
Copy link
Contributor

jsjoeio commented Aug 29, 2022

I am looking at the Material Icons now. Here are couple options:

CloudCircle
image

Storage
image

@BrunoQuaresma thoughts? I'd like to pick one and fix this.

Notes to Self

Changes will be made here: https://github.com/coder/coder/pull/3118/files#diff-f219cd4f34f9300e65c1fd2c36abd018870d6c55e566f182af19ee07f6161b30

@kconley-sq
Copy link
Contributor

I'm nervous that CloudCircle may not fit for user-local workspaces that wouldn't be running in the cloud (e.g. #909). I think Storage might be okay, but to me it looks like a server rack or maybe a tower of disk platters that I'm worried may be too specific for arbitrary resources.

What do you think about Widgets? I think it may be a little more generic:
image

@BrunoQuaresma
Copy link
Collaborator Author

I really liked the @kconley-sq suggestion of using the widgets icon

@jsjoeio
Copy link
Contributor

jsjoeio commented Aug 30, 2022

What do you think about Widgets? I think it may be a little more generic:

Great idea! I agree, that looks a bit more generic. I'll go with that!

@jsjoeio jsjoeio linked a pull request Aug 30, 2022 that will close this issue
refactor: use WidgetsIcon for null resources #3754
Merged
@bpmct bpmct mentioned this issue Aug 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsjoeio jsjoeio

Labels
site Area: frontend dashboard
Projects
None yet
Milestone
EE
Development

Successfully merging a pull request may close this issue.

refactor: use WidgetsIcon for null resources coder/coder
4 participants
@BrunoQuaresma @jsjoeio @kylecarbs @kconley-sq