-
Notifications
You must be signed in to change notification settings - Fork 886
Agent Metadata #3480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I wonder whether there is just a small set of key metrics that basically everyone wants like CPU, memory, network IO that we could just implement on each supported platform. Or is each deployment a special snowflake in this regard such that template authors should be defining these? |
@spikecurtis it's a good inquiry. There is so much ambiguity around "compute resources" that I struggle to see how hard-coded metrics would be compatible with our product's tenet of flexibility. Some examples:
|
I like the idea of defining these in blocks. In many cases though, the metrics might already be being collected somewhere else though. For example, if you're launching workspaces as pods in a Kubernetes cluster, there are already going to be a lot of metrics available via a Prometheus stack. Perhaps a type of block to connect these by specifying a Prom endpoint and query? I think both the simple exec definitions and a way to link existing metrics would be desirable. |
This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity. |
It could be cool if there was a |
It'd be interesting if output would render as markdown... then you could do something like: echo [$(git rev-parse --abbrev-ref HEAD)](https://github.com/coder/coder/tree/$(git rev-parse --abbrev-ref HEAD)) Which would render as:
and be clickable in the UI... |
|
I see a lot of potential for these. Talking to @bpmct and @ammario yesterday I can visualize it being used for metrics as well:
|
How is this gonna work for docker/kubernetes where |
@bpmct — probably one of those two methods, but that the decision is left to the user. |
Are we going to include agent metadata in our Kubernetes example? Want to make sure we have a solid answer for monitoring Kubernetes CPU, memory, disk usage. |
Yeah, we should. I probably won't go through that effort in my PR though. |
I can update the templates after #6614 is merged. |
The original idea came from @kconley-sq.
Right now, Resource Metadata values are generated at workspace build time. For example:
The feature excels at showing workspace configuration but can't expose key dynamic information such as CPU usage, load average, and the number of active connections. Here's an alternate syntax that could capture these dynamic values:
The agent would execute the
value_cmd
. So, it could also make sense to configure dynamic metadata in thecoder_agent
definition block. However they are defined, I think it makes sense to expose these values in the Agent section of the resources table. See below:Ideas:
curl ifconfig.me
git status
The text was updated successfully, but these errors were encountered: