Skip to content

data race in terraform/provision_test.go:103 #3574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spikecurtis opened this issue Aug 18, 2022 · 0 comments · Fixed by #3579
Closed

data race in terraform/provision_test.go:103 #3574

spikecurtis opened this issue Aug 18, 2022 · 0 comments · Fixed by #3579
Assignees
@mafredri
Labels
api Area: HTTP API

Comments

@spikecurtis
Copy link
Contributor 

WARNING: DATA RACE
Write at 0x00c000055660 by goroutine 87:
  github.com/coder/coder/provisioner/terraform_test.TestProvision_Cancel.func1()
      /home/runner/work/coder/coder/provisioner/terraform/provision_test.go:103 +0x232
  testing.tRunner()
      /opt/hostedtoolcache/go/1.18.5/x64/src/testing/testing.go:1439 +0x213
  testing.(*T).Run.func1()
      /opt/hostedtoolcache/go/1.18.5/x64/src/testing/testing.go:1486 +0x47

Previous write at 0x00c000055660 by goroutine 86:
  github.com/coder/coder/provisioner/terraform_test.TestProvision_Cancel.func1()
      /home/runner/work/coder/coder/provisioner/terraform/provision_test.go:103 +0x232
  testing.tRunner()
      /opt/hostedtoolcache/go/1.18.5/x64/src/testing/testing.go:1439 +0x213
  testing.(*T).Run.func1()
      /opt/hostedtoolcache/go/1.18.5/x64/src/testing/testing.go:1486 +0x47

Goroutine 87 (running) created at:
  testing.(*T).Run()
      /opt/hostedtoolcache/go/1.18.5/x64/src/testing/testing.go:1486 +0x724
  github.com/coder/coder/provisioner/terraform_test.TestProvision_Cancel()
      /home/runner/work/coder/coder/provisioner/terraform/provision_test.go:95 +0x6f5
  testing.tRunner()
      /opt/hostedtoolcache/go/1.18.5/x64/src/testing/testing.go:1439 +0x213
  testing.(*T).Run.func1()
      /opt/hostedtoolcache/go/1.18.5/x64/src/testing/testing.go:1486 +0x47

Goroutine 86 (running) created at:
  testing.(*T).Run()
      /opt/hostedtoolcache/go/1.18.5/x64/src/testing/testing.go:1486 +0x724
  github.com/coder/coder/provisioner/terraform_test.TestProvision_Cancel()
      /home/runner/work/coder/coder/provisioner/terraform/provision_test.go:95 +0x6f5
  testing.tRunner()
      /opt/hostedtoolcache/go/1.18.5/x64/src/testing/testing.go:1439 +0x213
  testing.(*T).Run.func1()
      /opt/hostedtoolcache/go/1.18.5/x64/src/testing/testing.go:1486 +0x47
==================

c.f. https://github.com/coder/coder/actions/runs/2885899296/attempts/1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mafredri mafredri

Labels
api Area: HTTP API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Shadow err in TestProvision_Cancel to fix test race coder/coder
2 participants
@mafredri @spikecurtis