-
Notifications
You must be signed in to change notification settings - Fork 881
Sign Windows CLI #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We can't use osslsignencode because it doesn't support google cloud HSM. We will probably want to use jsign instead: https://ebourg.github.io/jsign/ |
This is how the GitHub CLI does it: Not sure if it's entirely applicable though... |
If we're ok with not doing extended validation signing then osslsignencode will be OK. |
Ahhhh |
This comment was marked as off-topic.
This comment was marked as off-topic.
depends on if we want extended validation or not... this is probably a 3 if not but could be up to an 8 if so |
This comment was marked as off-topic.
This comment was marked as off-topic.
Kyle wants this :) |
@kylecarbs - i just noticed this on windows machines that want to use VSCode Desktop, as it fails to run the coder cli. Hopefully this fixes this issue! |
Slotting this in as a candidate for our next sprint as several folks need this as a long-term solution for rolling out Coder to Windows users. |
Seems like the GitHub CLI does this pretty cleanly now: https://github.com/cli/cli/blob/c465d465a5c60dae4e4759b4383292dab3f77504/.github/workflows/deployment.yml#L136 |
Game plan:
|
|
@kylecarbs i think we need some instructions on how to allow for these new signed exes in tools like Cyberark. So far this is not working |
@michaelbrewer could you elaborate on what's not working? |
Unfortunately i don't have a windows machine or am the person responsible for approving signed exe. But users are still getting an Application Blocked error |
@kylecarbs @sreya - looks like it was signed as In the future exactness matter :) |
@michaelbrewer is all working now after that change? |
No unfortunately it is still being flagged and blocked by CyberArk. I am not sure how to resolve this. We tried both names. |
@kylecarbs good news, we where able to get the signed exec working, waiting on how to document a standard working instructions. |
Acceptance Criteria
As a user, I want the Coder CLI on Windows signed because of organization security policy and peace of mind that the CLI is secure.
Use osslsignencode to sign the Windows binary on Linux during release.
This is NOT the extended validation version.
Edit (04.18.24): We want to do extended validation as well
Edit: See #359 (comment) for game plan
The text was updated successfully, but these errors were encountered: