Skip to content

React 18 cleanup: fix act warnings and cleanup promises in test files #3626

Closed as not planned
@Kira-Pilot

Description

@Kira-Pilot

Several jest act warnings appeared after we upgraded to React 18 in #3353. We should clean these up, although they don't effect the passing of the test suite.

In addition, we overrode lint in the following test files:
site/src/pages/CreateWorkspacePage/CreateWorkspacePage.test.tsx
site/src/pages/UsersPage/UsersPage.test.tsx
site/src/pages/WorkspacePage/WorkspacePage.test.tsx,
specifically eslint-disable @typescript-eslint/no-floating-promises

We should remove these overrides once we fix some of the async issues with the tests.

To reproduce

cd site
yarn run test

Resources

Learn more about the act warnings here. Learn about their appearance in React 18 here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    siteArea: frontend dashboardstaleThis issue is like stale bread.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions