Skip to content

bug: Flashing agent health check occurs even when the workspace is off. #4033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sharkymark opened this issue Sep 12, 2022 · 2 comments · Fixed by #4185
Closed

bug: Flashing agent health check occurs even when the workspace is off. #4033

sharkymark opened this issue Sep 12, 2022 · 2 comments · Fixed by #4185
Milestone
EE

Comments

@sharkymark
Copy link
Contributor

sharkymark commented Sep 12, 2022 •
edited
Loading

Version: v0.8.14+e1afec6

I understand there is a health check of the Coder agent when in the workspace dashboard.

But it is odd behavior that if in the workspace list screen it shows a workspace stopped that it hovers in connecting status and the health check flashing icons when I drill into a stopped workspace's dashboard.

The code should know the workspace is off and not do the health check.

image

image
@kylecarbs
Copy link
Member

When offline, the agent shouldn't appear at all!

@sharkymark
Copy link
Contributor Author

That would make sense wouldn't it

@ammario ammario added this to the EE milestone Sep 21, 2022
kylecarbs added a commit that referenced this issue Sep 23, 2022
@kylecarbs
fix: Hide agent status when a workspace is stopped
39522a4 
Fixes #4033.
@kylecarbs kylecarbs mentioned this issue Sep 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
EE
Development

Successfully merging a pull request may close this issue.

fix: Hide agent status when a workspace is stopped coder/coder
3 participants
@sharkymark @kylecarbs @ammario