Skip to content

Can we just not display terraform variable names? #4261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matifali opened this issue Sep 29, 2022 · 7 comments
Closed

Can we just not display terraform variable names? #4261

matifali opened this issue Sep 29, 2022 · 7 comments
Assignees
@kylecarbs
Labels
design needed Request for more beauty site Area: frontend dashboard

Comments

@matifali
Copy link
Member

Screenshot from 2022-09-15 08-25-41

Can we just somehow do not display this internal terraform variable names var.cpu, var.ram etc
The description is enough to explain what to enter to the user.
It will also resolve #4073 as there is no need for a pretty variable name anymore.
@matifali matifali changed the title Can we just do not display this? Can we just do not display terraform variable names? Sep 29, 2022
@BrunoQuaresma
Copy link
Collaborator

I think the description is not mandatory but we may could display the description as primary and the var name as secondary text. If the description is not provided, the var name gets primary. Sounds good?

@kylecarbs
Copy link
Member

We're reworking this flow right now. I'll post some WIP screenshots as it gets further along.

@kylecarbs kylecarbs self-assigned this Sep 29, 2022
@kylecarbs kylecarbs added site Area: frontend dashboard design needed Request for more beauty labels Sep 29, 2022
@matifali
Copy link
Member Author

I think the description is not mandatory but we may could display the description as primary and the var name as secondary text. If the description is not provided, the var name gets primary. Sounds good?

Yes this sounds good

@matifali matifali changed the title Can we just do not display terraform variable names? Can we just not display terraform variable names? Sep 30, 2022
@bpmct
Copy link
Member

bpmct commented Oct 25, 2022

Closing as a duplicate of #4311

@bpmct bpmct closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2022
@matifali
Copy link
Member Author

Closing as a duplicate of #4311

Using a coder_parameter is not a simple solution while we already have terraform variables, and they do have a description field. If someone just wants to make the template creation page looks nice without making the actual main.tf too complex. Hiding the variable name is the simplest solution.
image

@matifali
Copy link
Member Author

@bpmct

@bpmct
Copy link
Member

bpmct commented Oct 26, 2022

@matifali the current plan is to deprecate variables (and only using them for template-wide settings/CI jobs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kylecarbs kylecarbs

Labels
design needed Request for more beauty site Area: frontend dashboard
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@BrunoQuaresma @kylecarbs @matifali @bpmct