Skip to content

feat: coder license list shows a unix date and not a human-readable date #4313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sharkymark opened this issue Oct 3, 2022 · 5 comments · Fixed by #7687
Closed

feat: coder license list shows a unix date and not a human-readable date #4313

sharkymark opened this issue Oct 3, 2022 · 5 comments · Fixed by #7687
Assignees
@rodrimaia
Labels
cli Area: CLI s2 Broken use cases or features (with a workaround). Only humans may set this.
Milestone
🧹 Sprint 0

Comments

@sharkymark
Copy link
Contributor

sharkymark commented Oct 3, 2022 •
edited
Loading

Version: v0.9.1+27c8345

I added an enterprise license to a Coder deployment and would like to know the end date.

There is no UI like in v1, and when I run coder license list it shows what appears to be a Unix date under exp which 1. I assume means the end date and 2. is meaningless to me.

It also seems like a security risk that a Salesforce identifier is exposed in this file.

image
@sreya sreya self-assigned this Oct 19, 2022
@sreya sreya removed their assignment Nov 4, 2022
@ammario ammario self-assigned this Dec 4, 2022
@ammario
Copy link
Member

ammario commented Dec 4, 2022

I agree the default output should be human-readable. There is no new security risk to showing the salesforce identifier here, as the license file already gives that information to the user.

@ammario ammario removed their assignment Dec 9, 2022
@kylecarbs kylecarbs added bug cli Area: CLI labels Dec 14, 2022
@bpmct bpmct added s3 Bugs that confuse, annoy, or are purely cosmetic s2 Broken use cases or features (with a workaround). Only humans may set this. and removed s3 Bugs that confuse, annoy, or are purely cosmetic labels Feb 9, 2023
@github-actions
Copy link

This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label May 11, 2023
@ammario
Copy link
Member

ammario commented May 14, 2023

@rodrimaia — you were working on the License UI so maybe this would be up your alley?

@github-actions github-actions bot removed the stale This issue is like stale bread. label May 15, 2023
@matifali
Copy link
Member

Also, shouldn't we display a table like docker/kubectl do instead of a Jason by default?
Currently the above command shows a Jason output.

@rodrimaia
Copy link
Contributor

@ammario Sure! assigning it to me! :)

@rodrimaia rodrimaia self-assigned this May 18, 2023
@rodrimaia rodrimaia added this to the 🧹 Sprint 0 milestone May 22, 2023
@ammario ammario removed the sprint-0 label May 22, 2023
This was referenced May 25, 2023
Merged
Closed
@matifali matifali added the bug label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodrimaia rodrimaia

Labels
cli Area: CLI s2 Broken use cases or features (with a workaround). Only humans may set this.
Projects
None yet
Milestone
🧹 Sprint 0
Development

Successfully merging a pull request may close this issue.

feat(licenses): show license_expires time as rfc3339 date coder/coder
7 participants
@sharkymark @rodrimaia @sreya @kylecarbs @ammario @matifali @bpmct