Skip to content

audit: add support for GitSSHKeys creation and deletion #4541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Kira-Pilot opened this issue Oct 13, 2022 · 2 comments
Closed

audit: add support for GitSSHKeys creation and deletion #4541

Kira-Pilot opened this issue Oct 13, 2022 · 2 comments
Assignees
@coadler

Comments

@Kira-Pilot
Copy link
Member

We should add audit logging support for GitSSHKeys creation and deletion.

When a user regenerates an SSH Key in the Web UI, we should log it. Question for product/BE: is this an 'update' or a 'creation'?

This ticket needs more clarity on what CLI commands should generate SSH key audit logs.
@Kira-Pilot Kira-Pilot mentioned this issue Oct 13, 2022
Merged
@coadler coadler self-assigned this Oct 13, 2022
@bpmct
Copy link
Member

bpmct commented Oct 13, 2022 •
edited
Loading

I'd consider "regenerating" an update. Creation and deletion only occurs when the user account is created/deleted

@coadler coadler mentioned this issue Oct 13, 2022
Merged
@Kira-Pilot
Copy link
Member Author

Looks like there's only regeneration for the SSH Key resource, and we have that handled in the above PR. Closing this, but @coadler please reopen with more details if I'm missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@coadler @Kira-Pilot @bpmct