Skip to content

There are 4 example templates that basically do the same thing - confusing - remove one #4651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sharkymark opened this issue Oct 19, 2022 · 4 comments · Fixed by #6849
Closed

There are 4 example templates that basically do the same thing - confusing - remove one #4651

sharkymark opened this issue Oct 19, 2022 · 4 comments · Fixed by #6849
Labels
stale This issue is like stale bread.

Comments

@sharkymark
Copy link
Contributor

Version: v0.10.1+3c40698

Besides the coder templates init being cluttered for way too long, there are 4 Docker templates that all have code-server in them, that for all intents and purposes are the same.

This one, has code-server in the image, so the startup_script doesn't install it, and only starts it.
https://github.com/coder/coder/blob/main/examples/templates/docker-code-server/main.tf

Please trim this down. I think one, that has dotfiles, is fine.

image
@bpmct
Copy link
Member

bpmct commented Oct 19, 2022

@ericpaulsen has a fix underway in #4634 which only shows "Develop in Docker." It will not have dotfiles support though

@github-actions
Copy link

This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Dec 19, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 26, 2022
@sharkymark sharkymark reopened this Dec 26, 2022
@sharkymark
Copy link
Contributor Author

I still propose removing so many docker templates. Just have 1. The Dockerfile one seems overly complicated.

@github-actions github-actions bot removed the stale This issue is like stale bread. label Dec 27, 2022
@github-actions
Copy link

This issue is becoming stale. In order to keep the tracker readable and actionable, I'm going close to this issue in 7 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Mar 28, 2023
@bpmct bpmct mentioned this issue Mar 28, 2023
Merged
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale This issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: reduce docker examples coder/coder
2 participants
@sharkymark @bpmct