Skip to content

audit: resource creation failure should result in an audit log entry #4724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #4726
Kira-Pilot opened this issue Oct 24, 2022 · 1 comment · Fixed by #5143
Closed
Tracked by #4726

audit: resource creation failure should result in an audit log entry #4724

Kira-Pilot opened this issue Oct 24, 2022 · 1 comment · Fixed by #5143

Comments

@Kira-Pilot
Copy link
Member

Kira-Pilot commented Oct 24, 2022

If someone attempts to create a workspace or template or whatever other resource and that creation fails, we should create an audit log for it.

At the time of ticket creation, we do not yet audit log login/logout, but we should consider this resource when completing this ticket. Related ticket #4431

The real issue is workspace build outcomes are not currently logged. We log the request (this almost always comes back as a 201), but do not follow up with the outcome. For an example, take a look at the comment below regarding workspace deletion.

We should continue to log workspace build requests with language that indicates the outcome isn't guaranteed, like:

"Admin requested the deletion of workspace test".

Then we should follow up with an audit log for the outcome, e.g. "Workspace test successfully deleted".

We should also log workspace build failures. Perhaps these failures (for start, stop, or delete) should all create the same audit log - we don't need a separate implementation for each.

@Kira-Pilot
Copy link
Member Author

We should make sure the failure is reflected in the badge status. This delete looks successful, but wasn't:
Screen Shot 2022-10-26 at 11 54 33 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant