Skip to content

access URL defaults to HTTPS when defined without a protocol #4783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ericpaulsen opened this issue Oct 27, 2022 · 2 comments · Fixed by #4835
Closed

access URL defaults to HTTPS when defined without a protocol #4783

ericpaulsen opened this issue Oct 27, 2022 · 2 comments · Fixed by #4835

Comments

@ericpaulsen
Copy link
Member

ericpaulsen commented Oct 27, 2022 •
edited
Loading

when using an access URL without specifying a protocol, (e.g. --access-url=35.xxx.xxx.206), the Coder agent will default to dialing the server over HTTPS, causing the connection to hang:

⢎⡀ Waiting for connection from main ...

the fix here is to simply update the access URL to be --access-url=http://35.xxx.xxx.206. however, to prevent this behavior in the future, the Coder agent should default to HTTP (as curl does), or attempt to dial over both HTTP & HTTPS.
@bpmct
Copy link
Member

bpmct commented Oct 27, 2022

Hmm... some context on the decision here: #2874. @ericpaulsen @ammario What are your thoughts if it only defaulted to HTTP if it was an IP address but HTTPS for domains?

@ammario
Copy link
Member

ammario commented Oct 27, 2022

Hmm... some context on the decision here: #2874. @ericpaulsen @ammario What are your thoughts if it only defaulted to HTTP if it was an IP address but HTTPS for domains?

This trade off makes sense to me. We could also fail to start if a domain is provided w/o a protocol.

@f0ssel f0ssel mentioned this issue Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: error if protocol isn't specified in --access-url coder/coder
3 participants
@ammario @ericpaulsen @bpmct