Skip to content

packages.yaml workflow does not run on a new release. #5137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matifali opened this issue Nov 19, 2022 · 3 comments · Fixed by #5173
Closed

packages.yaml workflow does not run on a new release. #5137

matifali opened this issue Nov 19, 2022 · 3 comments · Fixed by #5173

Comments

@matifali
Copy link
Member

matifali commented Nov 19, 2022 •
edited
Loading

packages.yaml was merged in main before 0.12.7 and 0.12.8 releases but it did not run both of the times.

It seems like the trigger,

on:
  release:
    types: [published]

is not working.

There is some context and a similar issue. googleapis/release-please#766

A workaround can be to change the trigger to,

on:
  workflow_run:
    workflows: [release]
    types:
      - completed

This will run the workflow after the release workflow.

Another approach is to create a separate token, as discussed here, https://github.com/orgs/community/discussions/26875

cc @deansheather
@matifali
Copy link
Member Author

matifali commented Nov 19, 2022 •
edited
Loading

A manual run of the workflow also fails,
see the logs here,
https://github.com/matifali/coder/actions/runs/3503152146/jobs/5868221341

@deansheather
Copy link
Member

It's very odd that github isn't triggering it, but we can try this for sure

@matifali
Copy link
Member Author

matifali commented Nov 19, 2022 •
edited
Loading

A manual run of the workflow also fails, see the logs here, https://github.com/matifali/coder/actions/runs/3503152146/jobs/5868221341

Also, a manual trigger is failing. Please check the log when you find the time.

@matifali matifali mentioned this issue Nov 27, 2022
Merged
kylecarbs pushed a commit that referenced this issue Nov 27, 2022
@matifali
fix: packages.yaml action is not running on release trigger (#5173)
898ba11 
This commit is a workaround to run the `packages.yaml` action after the release action
Fixes #5137.
Check #5137 for context.
@matifali matifali mentioned this issue Dec 2, 2022
Closed
@matifali matifali mentioned this issue Jan 4, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: packages.yaml action is not running on release trigger
2 participants
@matifali @deansheather