Skip to content

flaky: TestAgent tailnet.(*Conn).Close() panics #5293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mtojek opened this issue Dec 5, 2022 · 1 comment · Fixed by #5295
Closed

flaky: TestAgent tailnet.(*Conn).Close() panics #5293

mtojek opened this issue Dec 5, 2022 · 1 comment · Fixed by #5295
Assignees
@mtojek

Comments

@mtojek
Copy link
Member

mtojek commented Dec 5, 2022 •
edited
Loading

Spotted in:
https://github.com/coder/coder/actions/runs/3617075588/jobs/6095609319
https://github.com/coder/coder/actions/runs/3605941257/jobs/6076793161
https://github.com/coder/coder/actions/runs/3601341028/jobs/6067023763 a different root cause
https://github.com/coder/coder/actions/runs/3621911592/jobs/6105957495

In most cases, the test fails after a few seconds. I'm going to dig deeper as it seems to be a common root cause.
@mtojek mtojek added the flake label Dec 5, 2022
@mtojek mtojek self-assigned this Dec 5, 2022
@mtojek
Copy link
Member Author

mtojek commented Dec 5, 2022

3/4 log dumps contain panic:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x179b4b4]

goroutine 1289 [running]:
github.com/coder/coder/tailnet.(*Conn).Close(0x0)
	/home/runner/work/coder/coder/tailnet/conn.go:488 +0x54
github.com/coder/coder/agent.(*agent).createTailnet.func1()
	/home/runner/work/coder/coder/agent/agent.go:266 +0x85
github.com/coder/coder/agent.(*agent).createTailnet(0xc0002eb560, {0x3b17630?, 0xc0007ad440}, 0xc0004c8d20)
	/home/runner/work/coder/coder/agent/agent.go:274 +0x95f
github.com/coder/coder/agent.(*agent).run(0xc0002eb560, {0x3b17630?, 0xc0007ad440})
	/home/runner/work/coder/coder/agent/agent.go:213 +0xca5
github.com/coder/coder/agent.(*agent).runLoop(0xc0002eb560, {0x3b17630, 0xc0007ad440})
	/home/runner/work/coder/coder/agent/agent.go:139 +0x185
created by github.com/coder/coder/agent.(*agent).init
	/home/runner/work/coder/coder/agent/agent.go:558 +0xf9a

@mtojek mtojek changed the title flaky: TestAgent many tests (unknown) flaky: TestAgent tailnet.(*Conn).Close() panics Dec 5, 2022
@mtojek mtojek mentioned this issue Dec 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: agent panics on closed network mtojek/coder
1 participant
@mtojek