Skip to content

cli: templates push and create wastes memory #5718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ammario opened this issue Jan 13, 2023 · 0 comments · Fixed by #6035
Closed

cli: templates push and create wastes memory #5718

ammario opened this issue Jan 13, 2023 · 0 comments · Fixed by #6035
Assignees
@ammario

Comments

@ammario
Copy link
Member

ammario commented Jan 13, 2023

coder templates push and coder templates create loads the entire archive into memory before posting to the server. The implementation generates a lot of heap activity, could run out of memory with large archives, and is slower than a streaming alternative.
@ammario ammario added the bug label Jan 13, 2023
@ammario ammario self-assigned this Feb 4, 2023
ammario added a commit that referenced this issue Feb 4, 2023
@ammario
Stream template upload
290b553 
Resolves #5718
@ammario ammario mentioned this issue Feb 4, 2023
Merged
ammario added a commit that referenced this issue Feb 4, 2023
@ammario
Stream template upload
3773e6f 
Resolves #5718
ammario added a commit that referenced this issue Feb 4, 2023
@ammario
Stream template upload
3bcc6fa 
Resolves #5718
ammario added a commit that referenced this issue Feb 4, 2023
@ammario
Stream template upload
5858a79 
Resolves #5718
ammario added a commit that referenced this issue Feb 4, 2023
@ammario
Stream template upload (#6035)
a422cc0 
Resolves #5718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ammario ammario

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: stream template upload coder/coder
1 participant
@ammario