Skip to content

Add workspace restart functionality to API #5800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mafredri opened this issue Jan 19, 2023 · 6 comments
Open

Add workspace restart functionality to API #5800

mafredri opened this issue Jan 19, 2023 · 6 comments
Labels
api Area: HTTP API cli Area: CLI need-backend Issues that need backend work

Comments

@mafredri
Copy link
Member

With #5799 we can now restart workspaces, however, the restart process is dependent on the client sticking around and issuing the start command after stop has completed.

We should implement restart functionality in the API so that we're not dependent on the client.

We could also consider creating retry-functionality so that if either stop or start fails, it can be retried a few times.

It'd be nice if this were implemented in the backend as a job type long-term... maybe we open an issue for it.

Originally posted by @kylecarbs in #5799 (review)
@mafredri mafredri mentioned this issue Jan 19, 2023
Merged
@mafredri mafredri added enhancement api Area: HTTP API cli Area: CLI labels Jan 19, 2023
@Kira-Pilot Kira-Pilot self-assigned this Mar 30, 2023
@Kira-Pilot Kira-Pilot mentioned this issue Apr 10, 2023
Closed
@Kira-Pilot Kira-Pilot removed their assignment Apr 14, 2023
@Kira-Pilot Kira-Pilot mentioned this issue Apr 14, 2023
Merged
@matifali
Copy link
Member

matifali commented Jul 7, 2023

bump

@matifali
Copy link
Member

matifali commented Nov 2, 2023

This would also help if someone would like to restart the workspace from inside a workspace.

@mafredri mafredri self-assigned this Feb 19, 2024
@mafredri mafredri removed their assignment Apr 2, 2024
@sreya
Copy link
Collaborator

sreya commented Apr 4, 2024

Not planned for now

@sreya sreya closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2024
@mafredri
Copy link
Member Author

mafredri commented Apr 4, 2024

@sreya I think this is a vital feature, would it be OK to keep it open? I'll try to grab it when I have a free cycle.

Motivation: I believe it's unexpected and a bad UX that reloading the Web UI, interrupting the CLI or losing network connectivity (Web/CLI) prevents a restart from completing, in these cases only the workspace stop sequence may be fulfilled.

@sreya
Copy link
Collaborator

sreya commented Apr 5, 2024

@mafredri sure if this is something that you'd like to pull into an upcoming sprint feel free, I'm was just trying to eliminate noise in the backlog 🙂

@sreya sreya reopened this Apr 5, 2024
@bpmct bpmct mentioned this issue Aug 30, 2024
Closed
@matifali
Copy link
Member

matifali commented Sep 27, 2024 •
edited
Loading

Related to #14857.

@matifali matifali closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2024
@matifali matifali reopened this Sep 27, 2024
@coder-labeler coder-labeler bot added the need-backend Issues that need backend work label Sep 27, 2024
@matifali matifali removed the feature label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Area: HTTP API cli Area: CLI need-backend Issues that need backend work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mafredri @sreya @matifali @Kira-Pilot