Skip to content

rich parameters: support for disk size #5978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bpmct opened this issue Feb 2, 2023 · 4 comments · Fixed by #6046
Closed

rich parameters: support for disk size #5978

bpmct opened this issue Feb 2, 2023 · 4 comments · Fixed by #6046
Assignees
@mtojek
Milestone
Rich Parameters GA

Comments

@bpmct
Copy link
Member

bpmct commented Feb 2, 2023

PVCs in Kubernetes (and many cloud APIs) cannot have their size decreased, only increased. We’ll need some special parameter validation to prevent this from happening.

image
@kylecarbs
Copy link
Member

@bpmct I believe in your spec a while ago you had an increment_only option in the validation block. This is something we should probably add.

@mtojek mtojek mentioned this issue Feb 3, 2023
Merged
@mtojek
Copy link
Member

mtojek commented Feb 3, 2023 •
edited
Loading

I've already started working on this. You can take a look at the pull request to make sure it's aligned with your vision.

@kylecarbs
Copy link
Member

monotonic is a much better keyword for it!

@bpmct
Copy link
Member Author

bpmct commented Feb 3, 2023

TIL what monotonic means :)

@mtojek mtojek self-assigned this Feb 6, 2023
This was referenced Feb 6, 2023
Merged
Closed
@bpmct bpmct added this to the Rich Parameters GA milestone Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
Rich Parameters GA
Development

Successfully merging a pull request may close this issue.

feat!: Validate monotonic numbers for rich parameters mtojek/coder
3 participants
@kylecarbs @mtojek @bpmct