Skip to content

tokens: coder tokens ls is confusing for owners #6214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #6110
bpmct opened this issue Feb 14, 2023 · 2 comments · Fixed by #6227 or #6325
Closed
Tracked by #6110

tokens: coder tokens ls is confusing for owners #6214

bpmct opened this issue Feb 14, 2023 · 2 comments · Fixed by #6227 or #6325
Assignees
@Kira-Pilot
Labels
s2 Broken use cases or features (with a workaround). Only humans may set this.

Comments

@bpmct
Copy link
Member

bpmct commented Feb 14, 2023 •
edited
Loading

Continuing #5935: When an Coder admin (owner) runs coder tokens ls, they see a list of all users' tokens. However, I find this experience quite jarring:

  • The expected behavior for most CLIs will only list the user's API tokens, not all users' API tokens
  • There is no way to tell which user owns each token

I'd like to suggest the following behavior:

  • By default, only show the user's tokens on coder tokens ls (and the web view, if appropriate)
  • Add coder tokens ls -all to show all users' tokens (we have this for workspaces)
  • Add an "owner" column to show who created/owns the token. Perhaps this only shows up with coder tokens ls --all
@bpmct bpmct added bug s2 Broken use cases or features (with a workaround). Only humans may set this. labels Feb 14, 2023
@bpmct bpmct mentioned this issue Feb 14, 2023
Closed
7 tasks
@bpmct bpmct changed the title tokens: coder tokens ls is confusing for admins tokens: coder tokens ls is confusing for owners Feb 14, 2023
@Kira-Pilot Kira-Pilot self-assigned this Feb 15, 2023
@Kira-Pilot
Copy link
Member

@bpmct do we want the owner column to show the userID or the username? username is more readable obviously, but userID is unique.

@bpmct
Copy link
Member Author

bpmct commented Feb 15, 2023

let's do username :)

@Kira-Pilot Kira-Pilot mentioned this issue Feb 17, 2023
Merged
@Kira-Pilot Kira-Pilot mentioned this issue Feb 23, 2023
Merged
@matifali matifali added the bug label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kira-Pilot Kira-Pilot

Labels
s2 Broken use cases or features (with a workaround). Only humans may set this.
Projects
None yet
Milestone
No milestone
3 participants
@matifali @Kira-Pilot @bpmct