Skip to content

Support multiple vs code channels for "VS Code Desktop" button #6267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
phorcys420 opened this issue Feb 17, 2023 · 5 comments · Fixed by #7730
Closed

Support multiple vs code channels for "VS Code Desktop" button #6267

phorcys420 opened this issue Feb 17, 2023 · 5 comments · Fixed by #7730
Labels
s2 Broken use cases or features (with a workaround). Only humans may set this.

Comments

@phorcys420
Copy link
Member

phorcys420 commented Feb 17, 2023 •
edited
Loading

Currently, the "VSCode desktop" button only supports VSCode stable because the URI handlers differ (vscode://coder.coder-remote/open[...] needs to be vscode-insiders://coder.coder-remote/open[...] in my case).

I think Coder should also support opening in different IDEs if you're going to support different VSCode channels anyways.

It'd be nice to be able to set something like "editor preference" in user settings with a tickbox to persist or not accross browsers.
@matifali
Copy link
Member

I recently switched to vscode insiders channel and can not more use the VS Code Desktop Button.

I see the URI is being set here,

coder/site/src/components/VSCodeDesktopButton/VSCodeDesktopButton.tsx

Line 39 in 8778449

location.href = `vscode://coder.coder-remote/open?${query.toString()}`

I suggest one of the following approaches to solve this.

  1. We should try both vscode: and vscode-insider:
  2. Allow the users to configure the default vscode channel in (not yet available account wide settings feat: set dotfiles at account level #7272 feat: set secrets/environment variables at account level #7280 User-scoped default variables #2387)
  3. Display both of the buttons (Vs Code and VS Code Insider) simultaneously.

cc: @phorcys420 @bpmct @kylecarbs

@matifali matifali added bug s2 Broken use cases or features (with a workaround). Only humans may set this. labels May 15, 2023
@matifali matifali changed the title Support multiple IDEs for "VSCode desktop" Support multiple vs code channels for "VS Code Desktop" button May 15, 2023
@phorcys420
Copy link
Member Author

I'm all in for the second approach.

We should try both vscode: and vscode-insider:

I personally have both installed, which would make it annoying.

Display both of the buttons (Vs Code and VS Code Insider) simultaneously.

I guess this would be fine but is kind of visually bothering, and it wouldn't be a proper way to do it in the long run if we want to add other IDEs (thinking about jetbrains IDEs for example)

We could also let the template set a preferred desktop IDE.
Something like a property that'd define the URI.

For example, the "python-dev" template could set PyCharm, the "js-dev" one could set WebStorm, etc.

I see you've renamed the issue to reflect VSC channels only, but I'd like to see support for separate IDEs too.

@matifali
Copy link
Member

Number 3 is the quickest fix until we have the prerequisites for number 2.

IMO, IDE should always be a developer preference instead of templates. We should not force an IDE on a developer.

And for JetBrains IDEs Coder is developing a JetBrains gateway plugin that will allow using any of the IDEs using JetBrains's gateway, so setting JetBrains Gateway only will suffice.

@phorcys420
Copy link
Member Author

IMO, IDE should always be a developer preference instead of templates. We should not force an IDE on a developer.

I agree -- but in some cases having a different "recommended IDE" could be useful, although I think it could just be defined as a coder_app now that I think about it.

@matifali
Copy link
Member

As a workaround, I am able to use VS Code Insiders using the Coder Remote Extension.

@matifali matifali mentioned this issue May 31, 2023
Merged
@matifali matifali added the bug label Jun 6, 2023
@sharkymark sharkymark mentioned this issue Jun 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
s2 Broken use cases or features (with a workaround). Only humans may set this.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for insiders channel to "VS Code Desktop" button coder/coder
2 participants
@matifali @phorcys420