Skip to content

Squash all the commits so there is only one when we go live #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
misskniss opened this issue Mar 29, 2022 · 7 comments
Closed

Squash all the commits so there is only one when we go live #649

misskniss opened this issue Mar 29, 2022 · 7 comments
Assignees
Labels
docs Area: coder.com/docs
Milestone

Comments

@misskniss
Copy link

misskniss commented Mar 29, 2022

Description

Squash all commits into one commit before making repo public. This is common practice (evidence: part of policy on FB OSS Team). It also provides a clean history.

@jsjoeio jsjoeio changed the title Squassh all the commits so there is only one when we go live Squash all the commits so there is only one when we go live Mar 31, 2022
@misskniss misskniss added this to the V2 Beta milestone Apr 1, 2022
@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 4, 2022

@misskniss I see this is in this sprint. Are we planning to open-source this by the end of the sprint?

If not, we may want to move this to the next sprint. I also see some important tasks that need to happen before we can open-source this in BETA:

@greyscaled
Copy link
Contributor

In my honest opinion, if we're going to do this, we could also open a new fresh repo with no issues or PRs afresh. We could rename this one to coder/coder-mvp and when it's ready open coder/coder.

I guess I just don't understand what squashing accomplishes when the entire development history (merged/closed PRs, issues) are still here and available. If anything, it just seems like our authorship is getting erased.

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 4, 2022

In my honest opinion, if we're going to do this, we could also open a new fresh repo with no issues or PRs afresh. We could rename this one to coder/coder-mvp and when it's ready open coder/coder.

Wouldn't we want to keep that around? (PRs, issues) But I guess that would make for the argument to not squash.

I guess I just don't understand what squashing accomplishes when the entire development history (merged/closed PRs, issues) are still here and available. If anything, it just seems like our authorship is getting erased.

I believe the reasoning is that we release the project to the public from a clean slate. There may be legal implications though that we're not aware of. It may be worth getting @ammario's opinion too

@greyscaled
Copy link
Contributor

greyscaled commented Apr 4, 2022

I guess what I'm trying to say is that technically all of the history is still here. It's just whether we're at commit 1 or X. Squashing makes history harder to piece together, but the closed PRs and their closed issues etc are all still here.

I back the "clean slate" idea, I'm just challenging that this isn't a clean slate. It's like halfway that in the end takes away authorship from everyone lol.

I'd rather go the whole mile: fresh repo!

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 4, 2022

True! I did some googling but didn't find much. This was one of the requirements by the FB OSS Team before any project was open-sourced. I wish I knew why though.

@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 6, 2022

After chatting with team members, we don't see the value in doing this (value for Coder, customers or community). It does not bring any specific benefits besides starting with a clean slate. In additional, we would lose valuable historical data.

Therefore, we have decided not to do this

@jsjoeio jsjoeio closed this as completed Apr 6, 2022
@misskniss
Copy link
Author

We can chat more on this today at Grooming.
CC: @vapurrmaid @jsjoeio

@misskniss misskniss added the docs Area: coder.com/docs label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Area: coder.com/docs
Projects
None yet
Development

No branches or pull requests

4 participants