Skip to content

site: TemplateVariables form does not react to API errors #6667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mtojek opened this issue Mar 20, 2023 · 2 comments · Fixed by #6674
Closed

site: TemplateVariables form does not react to API errors #6667

mtojek opened this issue Mar 20, 2023 · 2 comments · Fixed by #6674
Assignees
@BrunoQuaresma

Comments

@mtojek
Copy link
Member

mtojek commented Mar 20, 2023

Screenshot 2023-03-20 at 09 16 08

As you can see on the screenshot, the provisioning job failed, but site decided to reassign versions (next API call) instead of showing a failure.

How to reproduce:

  1. Create a template from examples using fly.io
  2. Go to Variables.
  3. Click Submit.

As there is another bug, the API call fails with REQUIRED_TEMPLATE_VARIABLES, but form doesn't care :)
@BrunoQuaresma
Copy link
Collaborator

When I do it, I get the following error:

Screen Shot 2023-03-20 at 10 44 20

@mtojek
Copy link
Member Author

mtojek commented Mar 20, 2023

You need to use the special values for those vars. I will send them to you over slack.

@BrunoQuaresma BrunoQuaresma mentioned this issue Mar 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(site): Show job error on updating template variables coder/coder
2 participants
@BrunoQuaresma @mtojek