Skip to content

Fix DBAuthz return sql.ErrNoRows #6774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Emyrk opened this issue Mar 24, 2023 · 0 comments · Fixed by #7122
Closed

Fix DBAuthz return sql.ErrNoRows #6774

Emyrk opened this issue Mar 24, 2023 · 0 comments · Fixed by #7122
Assignees
@Emyrk

Comments

@Emyrk
Copy link
Member

Emyrk commented Mar 24, 2023

Currently dbauthz returns sql.ErrNoRows to maintain backwards compatibility. It is no longer an experiment, and this error hides actual unauthorized errors. This should be fixed, and return the proper error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Rbac errors should be returned, and not hidden behind 404 coder/coder
1 participant
@Emyrk