Skip to content

Registering a moon shouldn't take a URL and wildcard host #7101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
deansheather opened this issue Apr 12, 2023 · 1 comment · Fixed by #7224
Closed

Registering a moon shouldn't take a URL and wildcard host #7101

deansheather opened this issue Apr 12, 2023 · 1 comment · Fixed by #7224
Assignees
@Emyrk
Milestone
Workspace Proxies

Comments

@deansheather
Copy link
Member

The POST endpoint for workspace proxies should not take a URL or wildcard host and should default to NULL.

Instead, the "internal" registration endpoint that workspace proxies call on startup and periodically should post the URL and it should be written to the table.
@deansheather deansheather added this to the Moons GA 🌚 milestone Apr 12, 2023
@deansheather deansheather mentioned this issue Apr 17, 2023
Merged
@Emyrk Emyrk self-assigned this Apr 20, 2023
@Emyrk
Copy link
Member

Emyrk commented Apr 20, 2023

Added the self registering. Will drop the fields from the create endpoint and close this.

@Emyrk Emyrk mentioned this issue Apr 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
Workspace Proxies
Development

Successfully merging a pull request may close this issue.

chore: Remove url and wildcard url from moon create coder/coder
2 participants
@Emyrk @deansheather