-
Notifications
You must be signed in to change notification settings - Fork 888
Create new OIDC user #7126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Can we also somehow allow an OIDC user to log in to the same account with a password? |
@matifali I don't like the idea of having 2 authentication methods, feels confusing and a security issues imo. Is there a benefit to the larger security surface of 2 auths? Like if you use OIDC to log in, you might forget password auth exists. If it does not actually provide value, we should prefer to lock things down. The BE is also only designed for 1 login type atm. We would want to support multiple which is going to require schema changes and that will propagate to some UI pages. Is this worth the upside? |
We currently have https://coder.com/docs/v2/latest/cli/server#--oidc-allow-signups, but it's not particularly helpful since admins cannot manually add users as OIDC. We have this in Coder v1:
Related: #4505
Implementation notes
Open to other ideas, but I believe this should cover most cases.
type
modal in the “add user” dropdown withbuilt-in
andOIDC
.OIDC
should be selected by default.type
modal in the “add user” dropdown withbuilt-in
andGitHub
.GitHub
should be selected by default, unless OIDC is also also enabled. In this case, OIDC should be the default.Bonus
We don’t have to do this as a part of this issue if it is difficult, but it helps customers secure their deployment, which is a part of this. If we don’t do this, let me know and I can extract it to another issue.
If —disable-password-auth is enabled, we should not allow built-in accounts to be created via the UI or API. The backdoor command to create an admin user (in the help text of that flag) must still work.
The text was updated successfully, but these errors were encountered: