Skip to content

do not run go/ts tests for PRs that only target docs #7147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
matifali opened this issue Apr 16, 2023 · 0 comments · Fixed by #7134
Closed

do not run go/ts tests for PRs that only target docs #7147

matifali opened this issue Apr 16, 2023 · 0 comments · Fixed by #7134
Labels
docs Area: coder.com/docs

Comments

@matifali
Copy link
Member

matifali commented Apr 16, 2023 •
edited
Loading

We have a condition that should prevent running unnecessary tests for PRs that only target docs.

coder/.github/workflows/ci.yaml

Line 101 in d3356fa

docs-only: ${{ steps.filter.outputs.docs_count == steps.filter.outputs.all_count }}

But still, our ci is running all checks.
See https://github.com/coder/coder/actions/runs/4711074673/jobs/8355224760?pr=7048 for example.

cc: @mafredri, @deansheather
@matifali matifali changed the title do not run go/ts tests for prs that only target docs do not run go/ts tests for PRs that only target docs Apr 16, 2023
@deansheather deansheather mentioned this issue Apr 16, 2023
Merged
@bpmct bpmct added docs Area: coder.com/docs and removed bug labels Apr 27, 2023
@ammario ammario removed the ci/cd label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Area: coder.com/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: skip ts or go tests based on changed files coder/coder
3 participants
@ammario @matifali @bpmct