Skip to content

workspace actions: add new status badge to workspaces table #7349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kira-Pilot opened this issue May 1, 2023 · 4 comments · Fixed by #7530
Closed

workspace actions: add new status badge to workspaces table #7349

Kira-Pilot opened this issue May 1, 2023 · 4 comments · Fixed by #7530
Assignees

Comments

@Kira-Pilot
Copy link
Member

Kira-Pilot commented May 1, 2023

Background

Case: Workspace is failed but not stopped
Badge solution: make use of existing 'Failed' status badge

Case: Workspace is inactive and scheduled for deletion within 2 weeks' time
Badge solution: If in 14 days or less the workspace will be deleted, any status badge is replaced with a 'Impending deletion' status badge

@Kira-Pilot Kira-Pilot self-assigned this May 1, 2023
@Kira-Pilot Kira-Pilot added this to the Workspace Actions GA milestone May 1, 2023
@bpmct
Copy link
Member

bpmct commented May 1, 2023

Should "impending deletion" workspaces show toward the top of the list? I'm thinking of a case where a user has 25 workspaces, and they do not notice that the workspaces at the bottom (since they are inactive) are scheduled for deletion.

As I understand it, this is the only visual indicator on the dashboard that the workspace is impending deletion? That is, unless they directly navigate to the workspace page.

@Kira-Pilot
Copy link
Member Author

@bpmct We could show the 'impending' deletion workspaces first, although I wonder if we want to wait until we add full sorting capabilities to the workspaces table before we enforce such a specific sort.

My thought is that template admins will be using the table view much more than workspace owners. You are correct in noting that currently the only other deletion indicators are on the workspace page/build page, so an owner would have to click into a workspace to see those; however, owners will see a notification every time they use VS Code for any workspace with an impending deletion.

If this doesn't seem noticeable enough, we could also add a dismissible banner to the top of the /workspaces page: "You have workspaces that will be deleted soon. Use this filter to see them." or something similar.

Let me know what you'd prefer!

@bpmct
Copy link
Member

bpmct commented May 1, 2023

If this doesn't seem noticeable enough, we could also add a dismissible banner to the top of the /workspaces page: "You have workspaces that will be deleted soon. Use this filter to see them." or something similar.

Let me know what you'd prefer!

This seems like the best option IMO. I am curious about the dismiss behavior.

Would the "dismiss" be per-session, or stored in localStorage or something? If another workspace is scheduled, would the old dismiss be invalidated? I'd be concerned about A) it showing up all the time and B) it not showing up when another workspace is scheduled, that the owner may not have reviewed.

@Kira-Pilot
Copy link
Member Author

Kira-Pilot commented May 1, 2023

Would the "dismiss" be per-session, or stored in localStorage or something?

Yes, per session and stored in local storage as a list of workspaces to be deleted.

If another workspace is scheduled, would the old dismiss be invalidated?

Correct, we would invalidate local storage if the list was out of date.

Added ticket #7365 to capture this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants