Skip to content

workspace actions: add impending deletion banner to workspaces page #7365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Kira-Pilot opened this issue May 1, 2023 · 1 comment · Fixed by #7538
Closed

workspace actions: add impending deletion banner to workspaces page #7365

Kira-Pilot opened this issue May 1, 2023 · 1 comment · Fixed by #7538
Assignees
@Kira-Pilot
Milestone
Workspace Cleanup GA

Comments

@Kira-Pilot
Copy link
Member

  • Add a dismissible banner to the top of the /workspaces page: "You have workspaces that will be deleted soon. Use this filter to see them."
  • Banner should only be shown once per session (use local storage)
  • Banner should be redisplayed if new workspace is scheduled for deletion (local storage should store list of workspaces with impending deletions)
@Kira-Pilot Kira-Pilot added this to the Workspace Actions GA milestone May 1, 2023
@Kira-Pilot Kira-Pilot self-assigned this May 1, 2023
@Kira-Pilot Kira-Pilot mentioned this issue May 1, 2023
Closed
@Kira-Pilot Kira-Pilot mentioned this issue May 15, 2023
Merged
@BrunoQuaresma
Copy link
Collaborator

About this point:

Banner should only be shown once per session

I think this should always be shown until it is dismissed or ignored.

@Kira-Pilot Kira-Pilot mentioned this issue May 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kira-Pilot Kira-Pilot

Labels
None yet
Projects
None yet
Milestone
Workspace Cleanup GA
Development

Successfully merging a pull request may close this issue.

feat: add workspaces banner for impending deletion coder/coder
2 participants
@BrunoQuaresma @Kira-Pilot